chore: pass pseudocolumn feature flag as boolean rather than config #8246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8175 added a feature flag for the new ROWPARTITION/ROWOFFSET feature (KLIP-50) by passing around a KsqlConfig from which the feature flag was extracted. However, this means query properties must be merged with a base config (to create a config with overrides) for all queries, and resulted in a pull query performance regression. To avoid the performance hit of merging a config with overrides per query, this PR updates the query pathways to pass around a boolean for the feature flag, rather than the entire config.
Testing done
Updated unit tests.
Reviewer checklist