feat: add configurations around endpoint logging #8249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanConfluent
approved these changes
Oct 12, 2021
| try { | ||
| // do not log the query that was sent with the URI, since this may contain | ||
| // sensitive user information | ||
| final URI uriWithQueryString = new URI(routingContext.request().uri()); |
There was a problem hiding this comment.
uriWithoutQueryString?
Also, I think you can just ask for routingContext.request().path() if you want just the path, rather than having to construct it by hand.
There was a problem hiding this comment.
nice - thanks for the tip
| } | ||
| } | ||
|
|
||
| if (endpointFilter.isPresent() && endpointFilter.get().matcher(uri).matches()) { |
There was a problem hiding this comment.
Filter is a bit confusing because some filters take functions which retain their elements rather than remove them. Not sure if I have a suggestion for a name. KSQL_ENDPOINT_LOGGING_SKIP_ENDPOINT_CONFIG?
There was a problem hiding this comment.
I went with KSQL_ENDPOINT_LOGGING_IGNORED_PATHS_REGEX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Endpoint logging potentially contains sensitive information. This patch allows some more configuration to control this behavior by introducing two configurations:
Testing done
Unit testing
Reviewer checklist