chore: passing consistency token using request properties in HARouting #8312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpapavas
reviewed
Nov 4, 2021
ksqldb-engine/src/main/java/io/confluent/ksql/physical/pull/HARouting.java
Outdated
Show resolved
Hide resolved
patrickstuedi
force-pushed
the
request-properties1
branch
2 times, most recently
from
fe817c8
to
20c2d2f
Compare
vvcephei
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Thanks, @patrickstuedi !
Just one thing to add on top of @vpapavas 's comment.
ksqldb-engine/src/main/java/io/confluent/ksql/physical/pull/HARouting.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/physical/pull/HARouting.java
Outdated
Show resolved
Hide resolved
patrickstuedi
force-pushed
the
request-properties1
branch
4 times, most recently
from
baef55b
to
36b72a9
Compare
vpapavas
reviewed
Nov 8, 2021
...app/src/test/java/io/confluent/ksql/rest/integration/PullQueryConsistencyFunctionalTest.java
Show resolved
Hide resolved
guozhangwang
reviewed
Nov 8, 2021
...app/src/test/java/io/confluent/ksql/rest/integration/PullQueryConsistencyFunctionalTest.java
Outdated
Show resolved
Hide resolved
...app/src/test/java/io/confluent/ksql/rest/integration/PullQueryConsistencyFunctionalTest.java
Show resolved
Hide resolved
patrickstuedi
force-pushed
the
request-properties1
branch
5 times, most recently
from
e605095
to
a857c86
Compare
vpapavas
reviewed
Nov 10, 2021
...app/src/test/java/io/confluent/ksql/rest/integration/PullQueryConsistencyFunctionalTest.java
Show resolved
Hide resolved
vpapavas
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Thank you @patrickstuedi ! LGTM just add the check in the test that the CV is actually correct
patrickstuedi
force-pushed
the
request-properties1
branch
2 times, most recently
from
7bbcce1
to
2f8c9f3
Compare
patrickstuedi
force-pushed
the
request-properties1
branch
from
2f8c9f3
to
5315afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the practice introduced in #8264 this PR is using request properties to pass the consistency token between servers