fix: Makes tests wait only 500ms for consumer group cleanup #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
QueryCleanupServicewaits 30s on shutdown. For some hard to debug reason, in tests, I constantly getGroupNotEmptyExceptions for query ids of queries that have been deleted in tests. This makes mosts functional tests timeout at 30s.This PR makes that value a config and sets it to 500ms in functional tests. After all, when a server is shut down in a test, the state is going to be wiped out anyway. This makes many functional tests go from 40s to 10s in my testing which makes it much easier to deal with and will hopefully speed up our test runs.
Testing done
Ran tests.
Reviewer checklist