Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Netty for 5.5.x #8389

Merged
merged 2 commits into from
Nov 19, 2021
Merged

fix: upgrade Netty for 5.5.x #8389

merged 2 commits into from
Nov 19, 2021

Conversation

xjin-Confluent
Copy link
Contributor

@xjin-Confluent xjin-Confluent commented Nov 19, 2021

Description

Need to upgrade Netty to fix CVE. This is only for 5.5.x

Testing done

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@xjin-Confluent xjin-Confluent requested a review from a team as a code owner November 19, 2021 04:49
@xjin-Confluent xjin-Confluent changed the title Upgrade Netty Upgrade Netty for 5.5.x Nov 19, 2021
@xjin-Confluent xjin-Confluent changed the title Upgrade Netty for 5.5.x fix: upgrade Netty for 5.5.x Nov 19, 2021
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xjin-Confluent - I was sure I had merged this already to 5.5.x 🤔 not sure what happened. Anyway, can you make sure to follow the lead of this PR: https://github.com/confluentinc/ksql/pull/8338/files

we need Netty/VertX versions to be aligned.

@xjin-Confluent xjin-Confluent merged commit e95ff38 into 5.5.x Nov 19, 2021
@xjin-Confluent
Copy link
Contributor Author

@agavra Can you help with pint merge? This is only for 5.5.x. Thanks.

@agavra agavra deleted the fix5.5.x branch November 19, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants