fix: Fixes flaky ScalablePushBandwidthThrottleIntegrationTest caused by timeout #8410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because
ScalablePushBandwidthThrottleIntegrationTest
creates a server per test, the startup time is attributed to the test, so although there's a 2 minute limit, most of it can be taken up by this startup. When the test then runs, the server gets terminated part way through and you get a funny connection closed error rather than a timeout, leading to confusion.This ups the timeout of this test to prevent this.
Testing done
Ran the test and simulated slow startup and was able to reproduce flaky stacktraces.
Reviewer checklist