Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes flaky ScalablePushBandwidthThrottleIntegrationTest caused by timeout #8410

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

AlanConfluent
Copy link
Member

Description

Because ScalablePushBandwidthThrottleIntegrationTest creates a server per test, the startup time is attributed to the test, so although there's a 2 minute limit, most of it can be taken up by this startup. When the test then runs, the server gets terminated part way through and you get a funny connection closed error rather than a timeout, leading to confusion.

This ups the timeout of this test to prevent this.

Testing done

Ran the test and simulated slow startup and was able to reproduce flaky stacktraces.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@AlanConfluent AlanConfluent requested a review from a team as a code owner November 23, 2021 20:06
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a super long time to start, is there any way we can make it faster?

Copy link
Member

@nateab nateab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlanConfluent
Copy link
Member Author

that's a super long time to start, is there any way we can make it faster?

@agavra I agree. This is not ideal, but the test itself takes maybe 30 seconds at times to run which means that if the startup takes way too long, it can hit 2 minutes in really slow CI runs. I think the ideal solution would include speeding up the server startup time. That would be a good followup.

@AlanConfluent AlanConfluent merged commit fbbc076 into confluentinc:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants