feat: populate header columns #8416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2021 11:41
spena
reviewed
Nov 29, 2021
Comment on lines
384
to
385
| final Header header = | ||
| processorContext.headers().lastHeader(col.headerKey().get()); |
There was a problem hiding this comment.
Should this and the header == null ? null ? ByteBuffer.wrap(header.value()) below be part of a helper function in SourceBuilderUtils? This code is repeated in SourceBuilder too.
spena
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates SourceBuilder to add header data
Testing done
Manually tested + updated unit tests. Integration tests will be in another PR.
Reviewer checklist