feat: block inserting into sources with headers #8417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Nov 29, 2021
| @@ -144,6 +146,10 @@ public void execute( | |||
|
|
|||
| final DataSource dataSource = getDataSource(config, metaStore, insertValues); | |||
|
|
|||
| if (!verifyInsertValuesAllowed(insertValues.getColumns(), dataSource)) { | |||
| throw new KsqlException("Cannot insert into a HEADER column"); | |||
There was a problem hiding this comment.
It'd be good to display the column header name. Perhaps throwing the exception from inside the method would be helpful so you can customize the message. What about renaming the method too validateInsert() or throwIfInsertOnHeadersColumns()?
There was a problem hiding this comment.
Updated the messages
| @@ -280,5 +280,9 @@ private void throwIfInsertOnReadOnlyTopic( | |||
| throw new KsqlException("Cannot insert into read-only topic: " | |||
| + dataSource.getKafkaTopicName()); | |||
| } | |||
|
|
|||
| if (!dataSource.getSchema().headers().isEmpty()) { | |||
| throw new KsqlException("Cannot insert into a source with header columns"); | |||
There was a problem hiding this comment.
Instead of source, use the name of the source. The dataSource.getDataSourceType() returns the type.
added 2 commits
November 29, 2021 11:32
spena
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the following statements fail:
INSERT INTO ... SELECT ...if the target source has header columnsINSERT VALUES ...if one of the target columns is a header columnTesting done
Manually tested and added unit tests. Integration tests will be in another PR.
Reviewer checklist