fix: Consider topics created by join operations internal #8520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final String internalTopic2 = applicationId | ||
| + "-KTABLE-FK-JOIN-SUBSCRIPTION-RESPONSE-0000000012-topic"; | ||
| final String internalTopic3 = applicationId + "-something-repartition"; | ||
| final String internalTopic4 = applicationId + "-someting-changelog"; |
There was a problem hiding this comment.
suhas-satish
approved these changes
Dec 15, 2021
Gerrrr
force-pushed
the
fix-8456
branch
2 times, most recently
from
3f3b945
to
0c9865e
Compare
cadonna
reviewed
Dec 17, 2021
Comment on lines
377
to
379
| && (topicName.endsWith(KsqlConstants.STREAMS_CHANGELOG_TOPIC_SUFFIX) | ||
| || topicName.endsWith(KsqlConstants.STREAMS_REPARTITION_TOPIC_SUFFIX)); | ||
| || topicName.endsWith(KsqlConstants.STREAMS_REPARTITION_TOPIC_SUFFIX)) | ||
| || topicName.matches(KsqlConstants.STREAMS_JOIN_REGISTRATION_TOPIC_PATTERN) | ||
| || topicName.matches(KsqlConstants.STREAMS_JOIN_RESPONSE_TOPIC_PATTERN); |
There was a problem hiding this comment.
This expression does not seem completely correct. Currently it is A && (B || C) || D || E. Shouldn't it be A && (B || C || D || E)? Maybe that is also the reason you get a checkstyle error that you need to suppress.
If I am right, then we are missing some tests that check the negative case.
There was a problem hiding this comment.
Good catch! I fixed it and added checks for the negative cases in 9e2652e.
|
Even though CI is broken, I think that it is ok to merge it because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8456.
Ideally, we should probably rely on a standard predicate in KStreams, but given this issue is a release blocker, we can probably introduce this predicate to KStreams and update ksql's dependency in follow-up PRs.
Testing done
Reviewer checklist