Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow disabling Scalable Push Query ALOS to be set via config #8542

Conversation

AlanConfluent
Copy link
Member

Description

Allows scalable push queries to be set via sercer config, not just via the request.

Testing done

Tested the change manually and ran tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@AlanConfluent AlanConfluent requested a review from a team as a code owner December 17, 2021 19:15
@guozhangwang
Copy link
Contributor

Just to clarify, the config change still needs a bounce to be made effective right? Whereas a request would not.

@AlanConfluent
Copy link
Member Author

Just to clarify, the config change still needs a bounce to be made effective right? Whereas a request would not.

@guozhangwang Yes, that's right. They can both be used with this change, so they can still enable/disabled it with the request if they want, but by default, it will use the server config which requires a roll to change.

@AlanConfluent
Copy link
Member Author

Not sure why that top build link didn't get updated, it still shows the failed first build when there's a number 2 that passed. I'm going to merge.

@AlanConfluent AlanConfluent merged commit 7ac36e0 into confluentinc:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants