fix: SandboxKafkaTopicClient should use default replication factor if applicable #8551
Conversation
…applicable If replication factor `-1` is used (implying to use the broker default) the SandboxKafkaTopicClient created a mocked topic with replication factor 0 instead of using the broker default. If multiple statement are submitted as once (ie, via a file), later statement could inherit the incorrect replication factor and thus fail, which failes all statements in the file. Closes #4800
|
This fix should be included in |
|
@mjsax Build is red :( can you double check? Once it's in, can you ping me and I'll cherry pick stuff to |
|
This PR broke 3 tests. It's a little tricky to fix: For a proper fix, we need a change in AK. I opened a PR for the AK change, but it will take some time to get it merged: apache/kafka#11648 (could not find a good workaround within ksqlDB code base). As an intermediate solution, we could disable the three failing test? Thoughts? |
|
Hey @mjsax how come it's only the INSERT INTO tests in RecoveryTest that are failing? I'm fine with the overall approach of disabling the tests until the fix propagates, as long as we don't lose track of the ticket to reenable them, but I'm curious why it's only these tests that need the fix and not others. |
|
Thanks for asking. I never thought about it. Looking into more, the reason is that those tests use non-existing topic |
… applicable (#8551) If replication factor `-1` is used (implying to use the broker default) the SandboxKafkaTopicClient created a mocked topic with replication factor 0 instead of using the broker default. If multiple statement are submitted as once (ie, via a file), later statements inherit the incorrect replication factor of 0 and thus fail, which fails all statements in the file. Fix PR fixes SandboxKafkaTopicClient to use the correct default replication factor and thus allow to submit multiple dependent statement at once.
|
Merged to |
If replication factor
-1is used (implying to use the broker default) theSandboxKafkaTopicClient created a mocked topic with replication factor 0
instead of using the broker default.
If multiple statement are submitted as once (ie, via a file), later
statement could inherit the incorrect replication factor and thus fail,
which fails all statements in the file.
Closes #4800