Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json_keys UDF #8603

Merged
merged 1 commit into from
Jan 24, 2022
Merged

feat: add json_keys UDF #8603

merged 1 commit into from
Jan 24, 2022

Conversation

Gerrrr
Copy link
Contributor

@Gerrrr Gerrrr commented Jan 18, 2022

Description

This PR introduces a new UDF - json_keys that returns an array of object keys. See the corresponding section in KIP-59 for more details.

Testing done

Added unit and functional tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@Gerrrr Gerrrr requested review from JimGalasyn and a team as code owners January 18, 2022 13:53
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggestion.

@Gerrrr Gerrrr force-pushed the feat-udf-json_keys branch 4 times, most recently from 5f1e837 to eca2bd3 Compare January 24, 2022 09:21
@Gerrrr Gerrrr merged commit bb78fcd into master Jan 24, 2022
@Gerrrr Gerrrr deleted the feat-udf-json_keys branch January 24, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants