-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uses internal topics prefix for shared runtimes #8607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTTM!
@wcarlson5 should we change the logic in |
@guozhangwang do you mean when deleting internal topics? I think we do need to but it might require a bit more thought because we will need to change how that is done |
Yes I was thinking about the purging of internal topics upon terminating the query indeed. Please let me know what procedure changes we'd need to consider. |
@guozhangwang Sophie reminded me I already made that change. I just need to adapt the new thing to use the new prefix instead of the application like you mentioned. I am going to leave |
Okay, thanks! |
This caused an issue for running old queries on the same server as queries in the new runtime. The fix can be found here #9470 |
Without shared runtimes:
_confluent-ksql-default_query_CSAS_CART_EVENT_PRODUCT_1-Join-repartition
shared runtimes without change:
_confluent-ksql-default_query_-1-CSAS_CART_EVENT_PRODUCT_1-Join-repartition
shared runtimes with change:
_confluent-ksql-default_query-CSAS_CART_EVENT_PRODUCT_1-Join-repartition
Will remove the runtime Id from internal topics so that we will be able to use topic in a different application with later work
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist