Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reinstate the old KsqlRestClient.create overload #8761

Conversation

swist
Copy link
Member

@swist swist commented Feb 15, 2022

Description

Commit a33b1e6
has changed the create method signature without
deprecating the old one first, causing the drift benchmarks
to fail with:

java.lang.NoSuchMethodError: io.confluent.ksql.rest.client.KsqlRestClient.create(
	java/lang/String;
	java/util/Map;
	java/util/Map;
	java/util/Optional;
)
io/confluent/ksql/rest/client/KsqlRestClient;

We're just adding back the missing signagure

Testing done

No test changes, just added a basic sanity check that we don't remove the signature later down the line

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@swist swist requested a review from a team as a code owner February 15, 2022 10:54
Copy link
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @swist !

@swist swist force-pushed the bugfix/reinstate-missing-method-after-removal-without-deprecation branch from 7d3d3ce to 9194032 Compare February 15, 2022 11:01
@swist swist force-pushed the bugfix/reinstate-missing-method-after-removal-without-deprecation branch 2 times, most recently from 4c5ff9c to 6037136 Compare February 15, 2022 13:32
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KsqlRestClient is not a public API. Why can't we just update the benchmarks repo to pass the additional Optional.empty() param? I can make the change if you'd like.

Commit a33b1e6
has changed the `create` method signature without
deprecating the old one first, causing the drift benchmarks
to fail with:
```
java.lang.NoSuchMethodError: io.confluent.ksql.rest.client.KsqlRestClient.create(
	java/lang/String;
	java/util/Map;
	java/util/Map;
	java/util/Optional;
)
io/confluent/ksql/rest/client/KsqlRestClient;
```
We're just adding back the missing signagure
@swist swist force-pushed the bugfix/reinstate-missing-method-after-removal-without-deprecation branch from 6037136 to 36dc09e Compare February 15, 2022 16:35
@swist
Copy link
Member Author

swist commented Feb 15, 2022

@vcrfxia I've looked at updating the benchmarks repo - the call doesn't live in the benchmarks repo itself, rather in the drift framework one, we would have to do some additional maven-fu to make sure that picks the correct version - drift uses confluent.version ref while drift-benchmark uses a custom range to resolve the nano versions. The most reliable way is to bring back the missing signature like this PR does

@AlanConfluent AlanConfluent merged commit ee4a1bc into confluentinc:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants