fix: pass DCN_NULLPOINTER_EXCEPTION spotbugs error #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have changed our SpotBugs version to 4.5.3 which was causing: ``` [ERROR] Medium: Do not catch NullPointerException like in io.confluent.ksql.datagen.DataGen$Arguments$Builder.build() [io.confluent.ksql.datagen.DataGen$Arguments$Builder] At DataGen.java:[line 440] DCN_NULLPOINTER_EXCEPTION [INFO] ``` This change is SpotBugs compliant way of doing the same thing - explicit null checks, rather than delegating to a method that checks for null and throws NPE
cadonna
approved these changes
Feb 16, 2022
Comment on lines
+366
to
+379
| if (schemaFile == null) { | ||
| throw new ArgumentParseException("Schema file not provided"); | ||
| } | ||
| if (keyFormat == null) { | ||
| throw new ArgumentParseException("Message key format not provided"); | ||
| } | ||
| if (valueFormat == null) { | ||
| throw new ArgumentParseException("Message value format not provided"); | ||
| } | ||
| if (topicName == null) { | ||
| throw new ArgumentParseException("Kafka topic name not provided"); | ||
| } | ||
| if (keyName == null) { | ||
| throw new ArgumentParseException("Name of key column not provided"); |
There was a problem hiding this comment.
I would prefer to deduplicate code by having a method like
void requireArgumentsNotNull(final Object argument, final String errorMessage) {
if (argument == null) {
throw new ArgumentParseException(errorMessage);
}
}
But I am also fine with this.
There was a problem hiding this comment.
I'll land this and follow up separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have changed our SpotBugs version to 4.5.3 which was causing:
This change is SpotBugs compliant way of doing the same thing
that checks for null and throws NPE
Testing done
Verified that spotbugs is happy with the new code
Reviewer checklist