fix: Ensures response end handler is invoked just once #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanConfluent
force-pushed
the
fix_metrics_bug
branch
from
931fb07
to
63f17ee
Compare
agavra
approved these changes
Mar 4, 2022
| @@ -219,6 +233,10 @@ private void handleQueryPublisher( | |||
|
|
|||
| // When response is complete, publisher should be closed and query unregistered | |||
| routingContext.response().endHandler(v -> { | |||
| if (endedResponse.getAndSet(true)) { | |||
There was a problem hiding this comment.
super nit: let's extract this into a close(Closeable item) method that gets and sets, closes the underlying item and reports the metrics?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On http2, when a client connection is closed, the response end handler is called twice, so this prevents that. The metrics were getting double counted as a result.
Testing done
Wrote unit test and tested manually.
Reviewer checklist