Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: functional tests min version for lower bound #8922

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

pgaref
Copy link
Member

@pgaref pgaref commented Mar 23, 2022

Fixing functional tests min version typo

@pgaref pgaref requested a review from a team as a code owner March 23, 2022 18:50
@pgaref pgaref changed the title docs: functional tests README typo docs: functional tests typo Mar 23, 2022
@pgaref pgaref changed the title docs: functional tests typo fix(docs): functional tests min version for lower bound Mar 23, 2022
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, first contribution -- thanks @pgaref ! Can you change the PR title back to "docs" instead of "fix(docs)", though? Anything marked as "fix" will show up in our auto-generated changelog, which we don't want for changes which are not of user interest.

@pgaref pgaref changed the title fix(docs): functional tests min version for lower bound docs: functional tests min version for lower bound Mar 23, 2022
@pgaref
Copy link
Member Author

pgaref commented Mar 23, 2022

Woohoo, first contribution -- thanks @pgaref ! Can you change the PR title back to "docs" instead of "fix(docs)", though? Anything marked as "fix" will show up in our auto-generated changelog, which we don't want for changes which are not of user interest.

Thanks @vcrfxia ! Sure thing, updated

@pgaref pgaref merged commit c33ee7b into confluentinc:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants