chore: remove SqlFormatInjector as obsolete #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pgaref
approved these changes
Mar 25, 2022
vcrfxia
added a commit
to vcrfxia/ksql
that referenced
this pull request
Mar 28, 2022
2 tasks
vcrfxia
added a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SqlFormatInjector was introduced back when ksql executed existing queries from the sql statements themselves (see #3037 for context). At the time, it was important that statements were formatted prior to execution in QTT since they'd be formatted before being read back and executed live. Now that ksql executes existing queries from query plans rather than the raw sql statements, this is no longer necessary.
Besides cleaning up old code, this will allow us to relax the assumption that all the necessary info for executing a query is contained in the sql statement itself. For example, there might be configs or other properties specified outside the statement (e.g., by the ksql server or server version) that affect query execution as well. See #8934 for an example.
Testing done
The existing code is test-only, so removing this has no production impact.
Reviewer checklist