fix: wait longer while waiting for expected spq #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixed another flakey spq integration test so going to try to add it here as well in case it helps.
|
|
agavra
reviewed
Apr 4, 2022
| @@ -280,6 +280,11 @@ private void assertExpectedScalablePushQueries( | |||
| || !metadata.getScalablePushRegistry().get().latestHasAssignment()) { | |||
| return false; | |||
| } | |||
| try { | |||
There was a problem hiding this comment.
assertThatEventually has a backoff built into it. You can configure it with any of these options:
public static <T> T assertThatEventually(
final Supplier<String> message,
final Supplier<? extends T> actualSupplier,
final Matcher<? super T> expected,
final long timeout,
final TimeUnit unit,
final long initialPausePeriodMs,
final long maxPausePeriodMs,
final ExceptionHandling exceptionHandling
) {
There was a problem hiding this comment.
added a longer period pause
agavra
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixed another flakey spq integration test so going to try to add it here as well in case it helps.