fix: fail validation on create connector if connector already exists #9014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick follow-up to #8999 (specifically, this discussion): for
CREATE CONNECTOR
statements that do not includeIF NOT EXISTS
in the statement, these statements will fail if a connector with the same name already exists. Currently, this failure happens during ksql's execute phase. Ideally, the failure would occur during ksql's validation phase, in order to fail fast so that no statements (in a multi-statement request) are executed. This PR adds a check for this case during validation accordingly.A consequence of this PR is that users are now required to have permissions to list existing connectors in order to issue CREATE CONNECTOR statements (even for statements that do not include
IF NOT EXISTS
). We believe this is inline with the desired security model for ksql, and are OK with this consequence.Testing done
Unit + integration.
Reviewer checklist