feat: add metric for query restarts #9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stevenpyzhang
force-pushed
the
query-restart-metric
branch
2 times, most recently
from
c2d027b
to
dbe454e
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
from
dbe454e
to
743de03
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
2 times, most recently
from
7efdfb6
to
4105ef9
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
from
4105ef9
to
7f3427a
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
2 times, most recently
from
afba69c
to
9c12741
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
2 times, most recently
from
1e924bc
to
2710ed0
Compare
stevenpyzhang
force-pushed
the
query-restart-metric
branch
from
2710ed0
to
8a0a310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a metric that reports the number of times a query has restarted streams threads (wherever we return a
StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse.REPLACE_THREADAlso made the retry log more granular in QueryMetadataImpl, the retires count was shared across all streams threads which was kind of annoying when testing this out.
Testing done
Unit testing
bean name
Reviewer checklist