feat: assert not exists topic #9086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
reviewed
May 2, 2022
| LOG.warn("Will skip topic config check for topic non-existence assertion."); | ||
| } | ||
| if (topicExists) { | ||
| throw new KsqlException("Topic " + topic + " exists"); |
There was a problem hiding this comment.
I'm 95% sure, but just to make sense, but this logic is instead the call which is retried, so if the topic is being deleted, the assertion can pass, etc, etc, right? (Still waiting for my coffee to kick in.)
There was a problem hiding this comment.
Yup, if this fails then the entire assertTopic method is retried until the timeout
jnh5y
approved these changes
May 2, 2022
We also need to update the Java client and the migration tool, and we need to do all this again for |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
NOT EXISTStoASSERT TOPICwhich asserts that a topic doesn't existTesting done
Manual, unit+integration tests
Reviewer checklist