feat: clean up processing log metric #9105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
force-pushed
the
clean-up-processing-log-metric
branch
from
bb012ce
to
28456d8
Compare
stevenpyzhang
force-pushed
the
clean-up-processing-log-metric
branch
from
28456d8
to
03f4265
Compare
stevenpyzhang
force-pushed
the
clean-up-processing-log-metric
branch
from
3f56bde
to
a64416a
Compare
rodesai
reviewed
May 11, 2022
| @@ -115,6 +116,14 @@ public synchronized Collection<ProcessingLogger> getLoggers() { | |||
| return processingLoggers.values(); | |||
| } | |||
|
|
|||
| @Override | |||
| public synchronized Collection<ProcessingLogger> getLoggersWithSubstring(final String substr) { | |||
There was a problem hiding this comment.
I think we should be a bit more careful and do a prefix match here, and rename to getLoggersWithPrefix
There was a problem hiding this comment.
updated to getLoggersWithPrefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #9035
Clean up the metrics by closing all processing logs associated with a push query when closing them.
Testing done
unit test, updated integration test
Verified metrics disappear in jconsole when terminating queries
Reviewer checklist