feat: add support for assert statements to migration tool #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
reviewed
May 12, 2022
| @@ -266,6 +268,8 @@ private void shouldApplyMigrations() throws Exception { | |||
| configFilePath, | |||
| migrationsDir, | |||
| "CREATE STREAM ${streamName} (A STRING) WITH (KAFKA_TOPIC='FOO', PARTITIONS=1, VALUE_FORMAT='JSON');\n" + | |||
| "ASSERT TOPIC FOO WITH (PARTITIONS=1) TIMEOUT 5 SECONDS;\n" + | |||
| "ASSERT NOT EXISTS SCHEMA ID 3 TIMEOUT 5 SECONDS;\n" + | |||
There was a problem hiding this comment.
What would happen to a migration script if an assert failed?
Is that case worth testing? (Admittedly, it may be a pain.)
There was a problem hiding this comment.
Same thing that would happen if any other statement fails - the migration completes exceptionally and the error is logged with something like Failed to execute sql: ASSERT TOPIC.... Error: Topic exists
Unfortunately the integration test only tests the happy path
jnh5y
approved these changes
May 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What the title says.
Parses
ASSERTcommands in migrations and runs them with the Java client. If the assertion fails, then the migration will be halted.Testing done
Manual, unit, integration
Reviewer checklist