-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support pausing/resuming persistent queries #9203
Merged
Merged
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f79cb2e
feat: Support pausing/resuming persistent queries
jnh5y 986c58f
Update ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/co…
jnh5y 8beade9
Update ksqldb-rest-app/src/test/java/io/confluent/ksql/rest/integrati…
jnh5y 49bbc55
Responding to reviewer comments.
jnh5y 9a57220
Removing unused code.
jnh5y 78db5a2
Removing fromStreamsStateCounts.
jnh5y 77a1cfe
Fixing checkstyle.
jnh5y d4c2683
Reviewer comments.
jnh5y 16af4d9
fix: Removing reverted configuration org.apache.kafka.streams.Streams…
jnh5y a99d9fe
Noting what needs to be fixed in the PRIT.
jnh5y f52ce77
Merge remote-tracking branch 'origin/master' into feat-6403-pause-resume
jnh5y 87bcb29
Merge remote-tracking branch 'origin/master' into feat-6403-pause-resume
jnh5y f0a9646
Merge remote-tracking branch 'origin/feat-6403-pause-resume' into fea…
jnh5y 4ce658b
Removing unnecessary {Pause|Resume}QueryEntity classes.
jnh5y b424631
Small clean-ups in PRIT.
jnh5y 841c7a4
Merge remote-tracking branch 'origin/master' into feat-6403-pause-resume
jnh5y caa509e
Addressing changes.
jnh5y f91a8b8
Responding to comments.
jnh5y 556545b
Responding to reviewer feedback.
jnh5y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
...cli/src/main/java/io/confluent/ksql/cli/console/table/builder/PauseQueryTableBuilder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2022 Confluent Inc. | ||
* | ||
* Licensed under the Confluent Community License (the "License"; you may not use | ||
* this file except in compliance with the License. You may obtain a copy of the | ||
* License at | ||
* | ||
* http://www.confluent.io/confluent-community-license | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.confluent.ksql.cli.console.table.builder; | ||
|
||
import io.confluent.ksql.cli.console.table.Table; | ||
import io.confluent.ksql.rest.entity.PauseQueryEntity; | ||
|
||
/** | ||
* This builder is only used to pause persistent queries. | ||
*/ | ||
public class PauseQueryTableBuilder implements TableBuilder<PauseQueryEntity> { | ||
|
||
@Override | ||
public Table buildTable(final PauseQueryEntity entity) { | ||
return new Table.Builder() | ||
.withColumnHeaders("Message") | ||
.withRow("Paused query \"" + entity.getQueryId() + '"') | ||
.build(); | ||
} | ||
} |
33 changes: 33 additions & 0 deletions
33
...li/src/main/java/io/confluent/ksql/cli/console/table/builder/ResumeQueryTableBuilder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2022 Confluent Inc. | ||
* | ||
* Licensed under the Confluent Community License (the "License"; you may not use | ||
* this file except in compliance with the License. You may obtain a copy of the | ||
* License at | ||
* | ||
* http://www.confluent.io/confluent-community-license | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.confluent.ksql.cli.console.table.builder; | ||
|
||
import io.confluent.ksql.cli.console.table.Table; | ||
import io.confluent.ksql.rest.entity.ResumeQueryEntity; | ||
|
||
/** | ||
* This builder is only used to resume persistent queries. | ||
*/ | ||
public class ResumeQueryTableBuilder implements TableBuilder<ResumeQueryEntity> { | ||
|
||
@Override | ||
public Table buildTable(final ResumeQueryEntity entity) { | ||
return new Table.Builder() | ||
.withColumnHeaders("Message") | ||
.withRow("Resumed query \"" + entity.getQueryId() + '"') | ||
.build(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand more about how pausing queries works with named topologies. I saw the note about it in the KIP but am still unclear about the details. I also have some questions about how pausing a KS app affects query status and the metrics emitted from the app. Let me try to catch you offline and then summarize the interesting points here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Did our conversations at the KSE on-site answer these questions well enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I meant to post an update here shortly afterwards but now it'll be a good memory exercise 😆 :