Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: improve error message for missing key #9246

Merged
merged 4 commits into from
Jul 12, 2022
Merged

MINOR: improve error message for missing key #9246

merged 4 commits into from
Jul 12, 2022

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jul 7, 2022

I have encountered multiple times, that uses cannot read this error message, because they don't know what "projection" means...

@mjsax mjsax requested a review from a team as a code owner July 7, 2022 19:47
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022 •
edited by cla-assistant bot
Loading

CLA assistant check
All committers have signed the CLA.

vcrfxia
vcrfxia approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think some QTTs (in joins.json) might need to be updated before you get a passing build.

@mjsax mjsax merged commit f2e4991 into confluentinc:master Jul 12, 2022
@mjsax mjsax deleted the improve-error branch July 12, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjsax @CLAassistant @vcrfxia