PR feedback 4th round

confluentinc · Jun 14, 2024 · 1018042 · 1018042
1 parent f201885
commit 1018042
Show file tree

Hide file tree

Showing 3 changed files with 161 additions and 205 deletions.
diff --git a/src/rdkafka_fetcher.c b/src/rdkafka_fetcher.c
@@ -715,9 +715,6 @@ static rd_kafka_resp_err_t rd_kafka_fetch_reply_handle_partition(
                     (hdr.ErrorCode ==
                          RD_KAFKA_RESP_ERR_NOT_LEADER_FOR_PARTITION ||
                      hdr.ErrorCode == RD_KAFKA_RESP_ERR_FENCED_LEADER_EPOCH)) {
-                        // TODO: Remove
-                        fprintf(stderr,
-                                "asdasd in fetch partition reading tags\n");
                         *leader_tags_present = rd_true;
                         rd_kafka_buf_read_uvarint(rkbuf, &_tagcnt);
                         for (i = 0; i < (int)_tagcnt; i++) {

diff --git a/src/rdkafka_metadata.c b/src/rdkafka_metadata.c
@@ -1972,11 +1972,16 @@ rd_kafka_metadata_new_topic_with_partition_replicas_mock(int replication_factor,
             topics, topic_cnt, replication_factor, num_brokers);
 }
 
-/*
+/**
  * @brief Handle update of metadata received in the produce or fetch tags.
  *
- * @param rk: used to look up current metadata.
- * @param mdi: metadata parsed from the tags.
+ * @param rk Client instance.
+ * @param rko Metadata update operation.
+ *
+ * @locality main thread
+ * @locks none
+ *
+ * @return always RD_KAFKA_OP_RES_HANDLED
  */
 rd_kafka_op_res_t
 rd_kafka_metadata_update_op(rd_kafka_t *rk, rd_kafka_metadata_internal_t *mdi) {