Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[consumer] Add rack-awareness (KIP-881) to assignors #4252

Merged
merged 15 commits into from
Jun 10, 2023
Merged

[consumer] Add rack-awareness (KIP-881) to assignors #4252

merged 15 commits into from
Jun 10, 2023

Commits on Jun 5, 2023

  1. [consumer] Add rack-awareness (KIP-881) to range assignor

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    061b45f View commit details
    Browse the repository at this point in the history

  2. Fix some memory issues in unittests

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    804f241 View commit details
    Browse the repository at this point in the history

  3. Include metadata refactor changes

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    09d67ef View commit details
    Browse the repository at this point in the history

  4. Add rack-awareness (KIP-881) to sticky-assignor (#4274) 

    * [cooperative][manual commit] Prevent offsets from being committed when a rebalance is in progress and partitions are owned by consumer

* Add test

* Format

* Ensure the operation is thread safe

* Add missing test config

* Don't propagate results if we decide to skip committing

* fixing broken test

* fixing typo

* Add rack-awareness (KIP-881) to sticky-assignor

* Fix minor issues with commiting only when not rebalancing

* memory leak in test
* test naming
* test copyright

* Fix style and remove rd_list_add_const

---------

Co-authored-by: Roxane Fruytier <[email protected]>
Co-authored-by: William Morgan <[email protected]>
Co-authored-by: William Morgan <[email protected]>
    @milindl @roxelo @wmorgan6796
    4 people committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    ddcedb4 View commit details
    Browse the repository at this point in the history

  5. Remove unused functions/macros

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    ee0c0a4 View commit details
    Browse the repository at this point in the history

  6. Fix MSVC build issue

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1cb36e3 View commit details
    Browse the repository at this point in the history

  7. 4252 (KIP-881) Verify number of partitions with rack mismatch (#4289)

    @emasab @milindl
    emasab authored and milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    b4de1ee View commit details
    Browse the repository at this point in the history

  8. Use precomputed toppar-rack mapping for assignors

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    cb809f7 View commit details
    Browse the repository at this point in the history

  9. Strip changes from cooperative rebalance fix

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fb2c94f View commit details
    Browse the repository at this point in the history

  10. Fix style issues

    @milindl
    milindl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4ed1db8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Remove TODOs and address internal comments

    @milindl
    milindl committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    3d8d9f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Address review comments

    @milindl
    milindl committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8a31959 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Remove partition from currentPartitionConsumer in case of extra consumer

    @milindl
    milindl committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3ce509d View commit details
    Browse the repository at this point in the history

  2. Avoid recomputation of partition racks per topic

    @milindl
    milindl committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e07e4be View commit details
    Browse the repository at this point in the history

  3. Revert accidental commit which changed null checks

    @milindl
    milindl committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    30a26dc View commit details
    Browse the repository at this point in the history