Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Choose between consumer or producer commit modes #31

Merged
merged 11 commits into from
Nov 23, 2020
Merged

feature: Choose between consumer or producer commit modes #31

merged 11 commits into from
Nov 23, 2020

Commits on Nov 23, 2020

  1. Adds unit test method logging - something is wrong with the AutoServi… 

    …ce method (todo)
    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    dff070f View commit details
    Browse the repository at this point in the history

  2. feature: Choose between Consumer commit or Producer transactional com… 

    …mits

- Choose either Consumer sync or async commits
- Fixes confluentinc#25 confluentinc#25:
-- Sometimes a a transaction error occurs - Cannot call send in state COMMITTING_TRANSACTION confluentinc#25
- ReentrantReadWrite lock protects non-thread safe transactional producer from incorrect multithreaded use
- Wider lock to prevent transaction's containing produced messages that they shouldn't
- Implement non transactional synchronous commit sync properly
- Select tests adapted to non transactional as well
- Must start tx in MockProducer as well
- Adds supervision to poller
- Fixes a performance issue with the async committer not being woken up
- Enhances tests to run under multiple commit modes
- Fixes example app tests - incorrectly testing wrong thing and MockProducer not configured to auto complete
- Make committer thread revoke partitions and commit
- Have onPartitionsRevoked be responsible for committing on close, instead of an explicit call to commit by controller
- Make sure Broker Poller now drains properly, committing any waiting work
- Add missing revoke flow to MockConsumer wrapper
- Add missing latch timeout check
    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ff41d13 View commit details
    Browse the repository at this point in the history

  3. feature: Make Producer instance optional, adds convenience methods

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    0617198 View commit details
    Browse the repository at this point in the history

  4. docs: Explanations for concurrency limits

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    b8d7847 View commit details
    Browse the repository at this point in the history

  5. Delombok for Javadoc (allows references to Lombok elements in Javadoc)

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    fed55f0 View commit details
    Browse the repository at this point in the history

  6. bug: Fixes bug in commit linger, remove genesis offset (0) from testi… 

    …ng (avoid races), add ability to request commit
    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    97ddead View commit details
    Browse the repository at this point in the history

  7. docs: Elaborate on Why not more consumers? FAQ

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e1e9af0 View commit details
    Browse the repository at this point in the history

  8. test: Commit mode test improvements, bug fixes

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    cb83cee View commit details
    Browse the repository at this point in the history

  9. bug: By default, close without draining and when draining still poll … 

    …mailbox and commit normally
    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    a7267fd View commit details
    Browse the repository at this point in the history

  10. docs: Temporarily remove travis badges (travis deactivated for repo)

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ecfa631 View commit details
    Browse the repository at this point in the history

  11. docs: Fix code examples

    @astubbs
    astubbs committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    88261e9 View commit details
    Browse the repository at this point in the history