Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new topic configuration fields - message.timestamp.after.max.ms and message.timestamp.before.max.ms #341

Closed
Noel-Jones opened this issue Jan 3, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Noel-Jones
Copy link

Noel-Jones commented Jan 3, 2024

Following on from #339 I just got around to updating my code to set the fields message.timestamp.after.max.ms and message.timestamp.before.max.ms to the default values. Now I get the message

Error: error updating Kafka Topic "lkc-xxxx/xxx.customer.updates": "message.timestamp.after.max.ms" topic setting is read-only and cannot be updated. Read https://registry.terraform.io/providers/confluentinc/confluent/latest/docs/resources/confluent_kafka_topic for more details.
│ 
│   with confluent_kafka_topic.active["Development-dev_cluster_0-xxx.customer.updates"],
│   on topic.tf line 24, in resource "confluent_kafka_topic" "active":
│   24: resource "confluent_kafka_topic" "active" {

The provider needs to be updated to support setting of these fields. I am raising this as a new issue because it is a specific issue with a more significant impact that prevents me from being able to apply. If I set the config value I get the error shown above, if I don't set the field I get the error below!

Error: error updating Kafka Topic "lkc-xxxxx/dlq-oracle-erp.fct.customer.updates": reset to topic setting's default value operation (in other words, removing topic settings from 'configs' block) is not supported at the moment. Instead, find its default value at https://registry.terraform.io/providers/confluentinc/confluent/latest/docs/resources/confluent_kafka_topic and set its current value to the default value.
@linouk23 linouk23 added the enhancement New feature or request label Jan 3, 2024
@shriman-desikan
Copy link

We are also having this issue, it's preventing us from updating any existing topics using Terraform. This is definitely a bug versus an enhancement since it prevents you from updating any existing topics and the Error messages' fix also doesn't work.

@linouk23 linouk23 added bug Something isn't working and removed enhancement New feature or request labels Jan 4, 2024
@linouk23
Copy link
Contributor

linouk23 commented Jan 4, 2024

@Noel-Jones, @shriman-desikan thanks for creating this PR!

Could you confirm you are interested in the following 2 topic settings:

  • log.message.timestamp.before.max.ms
  • log.message.timestamp.after.max.ms

image

@shriman-desikan
Copy link

shriman-desikan commented Jan 4, 2024

Yes, those are the two topic settings that I guess should be editable going forward.

This all seems related to this KIP and Confluent's adoption of Kafka version 3.6.x, for more context.

Thank you!

@linouk23
Copy link
Contributor

linouk23 commented Jan 4, 2024

Thanks!

We have internally merged a fix and are planning to release a new version of the TF Provider today or tomorrow, which will include this fix. Thank you for your patience!

@linouk23
Copy link
Contributor

linouk23 commented Jan 5, 2024

@shriman-desikan @Noel-Jones

Update: we

Added a client side fix for "Add support for new topic configuration fields" issue (#341).

in our latest 1.57.0 version of TF Provider.

Thanks for waiting and let us know if you run into any issues when using the latest 1.57.0 version of TF Provider.

@linouk23 linouk23 closed this as completed Jan 5, 2024
@Noel-Jones
Copy link
Author

Thank you, v1.57 does resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants