Changed the Connect() method API
#7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieugusmini
force-pushed
the
fix-initial-connection-loop
branch
from
d04afc8
to
68bab02
Compare
cnf-swbae
approved these changes
Apr 24, 2023
added 3 commits
May 10, 2023 19:18
- Edited the Connect() method so it doesn't take a context as argument since it was a bit misleading with the presence of the Close() method. Also removed the for loop on the isReady field since it was doing heavy CPU operations. - Updated the documentation quite a bit - Added a GitHub action workflow to run the linter on the project - Renamed some configuration fields to follow the official reference documentation
Added a comment on the WithLogger option.
matthieugusmini
force-pushed
the
fix-initial-connection-loop
branch
from
96c7f11
to
28a86f0
Compare
Added a context to the parameter list to handle cancellation since we removed the timeout from the configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect()method so it doesn't take a context as argument since it was a bit misleading with the presence of theClose()method. Also removed the for loop on the isReady field since it was doing heavy CPU operations.