Migrate to Node16 resolution #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update PR description to explain why we are moving to node16 resolution? |
timostamm
reviewed
Oct 11, 2023
This was referenced Dec 13, 2023
Closed
|
@timostamm @smaye81 resurrecting this PR to migrate to node16. |
paul-sachs
added a commit
that referenced
this pull request
Dec 14, 2023
timostamm
reviewed
Mar 21, 2024
There was a problem hiding this comment.
@paul-sachs, we just switched protobuf-es to build with Node16 module resolution, see bufbuild/protobuf-es#754. It's not released yet, and connect-es has not been updated yet (see connectrpc/connect-es#887).
The changes here look good to me. Just left a couple of comments.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating everything to use node16 resolutions. This guarantees (via the tsc compiler) that the files we output match the expected import format for downstream tools. This also brings us into compliance with module resolution for node 16+, which is the minimum version of node we support and is the recommended value for libraries.
See detailed explanation here