Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Modules to 2 types: ActiveModule and PassiveModule #98

Merged
merged 34 commits into from
Jun 16, 2022
Merged

Generalize Modules to 2 types: ActiveModule and PassiveModule #98

merged 34 commits into from
Jun 16, 2022

Commits on Jun 13, 2022

  1. Use dynamic reflect.Select in main event loop 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    15aca91 View commit details
    Browse the repository at this point in the history

  2. Add dest_module field to event proto definitions 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    1305f75 View commit details
    Browse the repository at this point in the history

  3. Add generic (passive) modules 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    8d14376 View commit details
    Browse the repository at this point in the history

  4. Rename hash to digest in crypto implementation 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4f18010 View commit details
    Browse the repository at this point in the history

  5. Move default ISS module definitions to ISS package 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    9235d97 View commit details
    Browse the repository at this point in the history

  6. Generalize Hasher module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f970b23 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Generalize App module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    31fae4c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Generalize Crypto module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8cee9a0 View commit details
    Browse the repository at this point in the history

  2. Generalize WAL module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    83294f7 View commit details
    Browse the repository at this point in the history

  3. Generalize ClientTracker module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8932949 View commit details
    Browse the repository at this point in the history

  4. Generalize ReqestStore module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6cb41cd View commit details
    Browse the repository at this point in the history

  5. Generalize ISS protocol module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    eba24ed View commit details
    Browse the repository at this point in the history

  6. Separate event interceptor from modules 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    512bd37 View commit details
    Browse the repository at this point in the history

  7. Introduce the ActiveModule 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    18fc7ca View commit details
    Browse the repository at this point in the history

  8. Generalize Timer module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    fcc6907 View commit details
    Browse the repository at this point in the history

  9. Generalize Net module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7e8fef0 View commit details
    Browse the repository at this point in the history

  10. Simplify and clean up event and module handling 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    2c934b9 View commit details
    Browse the repository at this point in the history

  11. Remove unused dummy components 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    67415d8 View commit details
    Browse the repository at this point in the history

  12. Remove old module definitions 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    3ba5cbc View commit details
    Browse the repository at this point in the history

  13. Abstract foreign module names in ISS 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f4dcd0a View commit details
    Browse the repository at this point in the history

  14. Fix tests hanging on error 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    908acf9 View commit details
    Browse the repository at this point in the history

  15. Add Null module and use it as default ISS WAL 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7001729 View commit details
    Browse the repository at this point in the history

  16. Update chat demo app to use new modules 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0237ef4 View commit details
    Browse the repository at this point in the history

  17. Remove obsolete NullNet and make linter happy 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    9ac48c3 View commit details
    Browse the repository at this point in the history

  18. Sequential and concurrent event processing 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    416dfee View commit details
    Browse the repository at this point in the history

  19. Make Module implementations explicit 

    Use an explicit definition of the ImplementsModule function
in each Module implementation instead of including the Module interface
as an anonymous field.
This smells less like abusing OO concepts in a non-OO language.

Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    64f5e8b View commit details
    Browse the repository at this point in the history

  20. Safely apply events also to ActiveModules 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    706c296 View commit details
    Browse the repository at this point in the history

  21. Fix documentation of processModuleEvents 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    bd30747 View commit details
    Browse the repository at this point in the history

  22. Move Status() function modules to Module 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1819a8b View commit details
    Browse the repository at this point in the history

  23. Remove node status and ImplementsModule() panics 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    edb1c99 View commit details
    Browse the repository at this point in the history

  24. Do not export foreign module names in ISS 

    The foreign module names in ISS, currently defined as package-level
variables, are only a temporary measure until these values become part
of the ISS protocol configuration data structure. Until then, they stay
"hard-coded" this way.

Also, the OwnModuleName is renamed to issModuleName
(instead of ownModuleName)

Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a2f5b0d View commit details
    Browse the repository at this point in the history

  25. Fix and simplify some select statements 

    More concretely, in node.go and pkg/deploytest/deployment.go

Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f434280 View commit details
    Browse the repository at this point in the history

  26. Fix bug in stripping events, making debugging work 

    Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    23ba462 View commit details
    Browse the repository at this point in the history

  27. Simplify crypto implementation interface 

    Remove the "key-value store"-like methods for public key management.
If the crypto implementation needs to store public key information,
it should manage the public keys out-of-band.

Signed-off-by: Matej Pavlovic <[email protected]>
    @matejpavlovic
    matejpavlovic committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    c2f001f View commit details
    Browse the repository at this point in the history