Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from lazy_static to once_cell #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch from lazy_static to once_cell #218

wants to merge 1 commit into from

Conversation

alex
Copy link

@alex alex commented Aug 3, 2024

This will ultimately facilitate migrating to the std solution, once the MSRV is high enough.

@alex
Switch from lazy_static to once_cell
5a1e29a 
This will ultimately facilitate migrating to the std solution, once the MSRV is high enough.
@tamird tamird mentioned this pull request Aug 26, 2024
Open
@tamird
Copy link

tamird commented Aug 26, 2024

FWIW this was previously reverted in #137 over MSRV and #134 contains discussion.

@smoelius
Copy link

Can I ask where this currently stands?

once_cell's MSRV is 1.60: https://github.com/matklad/once_cell/blob/4fbd4a53509ca59c8e09efc2ab0a22f21de70f7e/Cargo.toml#L7

And console's is 1.56:

console/Cargo.toml

Line 13 in de2f15a

rust-version = "1.56.0"

Are there dependents that would be known to break if console's MSRV were bumped to 1.60?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex @tamird @smoelius