Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce the hold_max option for less jumpy Seek-implementing ProgressBarIters #642

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

djugei
Copy link
Contributor

@djugei djugei commented May 2, 2024

title basically :)

@djc
Copy link
Member

djc commented Aug 26, 2024

Hey, sorry for the slow feedback here.

I'm sympathetic to the need for this, but generally would prefer to avoid user-facing options -- as much as possible, I think indicatif should do the right thing out of the box. This seems like something that could be enabled by default, are there reasons this should remain an option?

@djugei
Copy link
Contributor Author

djugei commented Aug 26, 2024

i had a similar thought, the other usecase is that for example a footer is read first, in that case the progress bar would be stuck at 100% throughout.
lots of formats do that, especially archive formats.
for not having any options that would need some detection and special casing, which i decided against.

maybe changing the non-jumping behaviour to be the default behaviour and documenting when it should be switched off would be an option though?

@djugei
Copy link
Contributor Author

djugei commented Aug 27, 2024

another idea: once the first seek happens keep a log of the last 10 accesses around and set progress to the maximum, possibly switch it off if the last 10 accesses were sequential

@djc
Copy link
Member

djc commented Aug 27, 2024

another idea: once the first seek happens keep a log of the last 10 accesses around and set progress to the maximum, possibly switch it off if the last 10 accesses were sequential

I like the idea of applying some heuristics here. Want to do an implementation of that so we can review it?

@djugei
Copy link
Contributor Author

djugei commented Sep 9, 2024

@djc i have created an alternative implentation using a heuristic in #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants