Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite loops during command info parsing. #309

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

greg-1-anderson
Copy link
Member

Disposition

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Description

Note that we have parsed everything as soon as we enter the "parse" method, to avoid infinite loops.

Proposed replacement for #306

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.17%. Comparing base (f5e90aa) to head (6dee8b6).

Files Patch % Lines
src/Parser/CommandInfo.php 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                4.x     #309      +/-   ##
============================================
- Coverage     88.19%   88.17%   -0.02%     
- Complexity      781      783       +2     
============================================
  Files            46       46              
  Lines          2100     2105       +5     
============================================
+ Hits           1852     1856       +4     
- Misses          248      249       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greg-1-anderson greg-1-anderson merged commit 50a8d57 into 4.x Apr 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant