Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the golang version and enable gomod #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hakanmemisoglu
Copy link
Contributor

This PR aims to fix Travis build problem.

  • Upgrade version of golang to 1.11.12.
  • Enable gomod.

@jieyu
Copy link
Member

jieyu commented Aug 7, 2019

You need to update the generated pb.go file as well

@davidz627
Copy link
Contributor

Fixes: #377?

@hakanmemisoglu
Copy link
Contributor Author

hakanmemisoglu commented Aug 8, 2019

@davidz627 It fixes the problem. However, it created another one.
I am getting diff error: https://travis-ci.org/container-storage-interface/spec/jobs/569100580
make locally doesn't update the generated files. (Working on it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants