Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for asyncio download methods #243

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

fepas
Copy link
Contributor

@fepas fepas commented Jul 18, 2023

STONEBLD-1356

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • [n/a] Docs updated (if applicable)
  • [n/a] Docs links in the code are still valid (if docs were updated)

@brunoapimentel
Copy link
Contributor

Any chance we can also cover these lines? This would increase the coverage of this module to a good level.

Not sure how we'd do it though 🤔

@fepas fepas force-pushed the STONEBLD-1356 branch 9 times, most recently from ae85ff6 to a943f88 Compare July 20, 2023 13:28
@fepas fepas force-pushed the STONEBLD-1356 branch 2 times, most recently from 84796f2 to 225f8bb Compare July 20, 2023 22:29
@brunoapimentel
Copy link
Contributor

Overall, great work 👍

Just left two minor comments.

@ben-alkov
Copy link
Member

@fepas;

Coveralls reports missing coverage on LL110-113

Copy link
Contributor

@brunoapimentel brunoapimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We're still missing coverage in lines 110-113 and 113-139 because they proved quite tricky to test.

I believe the time we'd spend trying to get full coverage is probably not worth it, considering the main behavior is already covered.

tests/unit/conftest.py Outdated Show resolved Hide resolved
tests/unit/package_managers/test_general.py Outdated Show resolved Hide resolved
STONEBLD-1356

Signed-off-by: Felipe de Almeida <[email protected]>
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fepas fepas added this pull request to the merge queue Aug 11, 2023
Merged via the queue into containerbuildsystem:main with commit 2d17fea Aug 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants