Backup package(-lock).json update with local paths with V1 support #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For V2+ package.json(s) update only https and git sources with empty string. in package-lock.json update git and https package dependencies with empty string. STONEBLD-1108 Signed-off-by: Ladislav Kolacek <[email protected]>
Logic for fetching sources was moved to _resolve_npm Add unit tests for methods: * check_if_package_is_workspace * replace_dependency STONEBLD-1108 Signed-off-by: Ladislav Kolacek <[email protected]>
* Updated package.json files with local paths to packages were added to build-config.json * Promote npm test scenarios (npm_smoketest_lockfile1, npm_smoketest_lockfile2, npm_smoketest_lockfile3) to end to end tests * Add Containerfiles for new End to End tests * Change type of expected_cmd_output for end to end tests to list STONEBLD-1108 Signed-off-by: Ladislav Kolacek <[email protected]>
2 tasks
|
Closing this PR. V1 support for npm will not be included in Cachi2 project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might not need to support "deprecated" package-lock.json v1 for npm version 6,
but I'll backup this code changes in case we would need them.
Maintainers will complete the following section