-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document Yarn support in cachi2 #425
Conversation
I think we also want to have a complete example, following what has been done on other package managers: https://github.com/containerbuildsystem/cachi2/blob/main/docs/usage.md#usage-examples. I'm ok if this is done in a follow-up PR, though. |
Nope, that's a good point which needs to be addressed in this PR. |
409d2ac
to
88fb525
Compare
Added the change, however, @brunoapimentel I'd like to ask you to move your sample-nodejs-app Yarn modifications to the main cachito nodejs repo which my docs changes refer to. Also, I think you'll need to do a few cosmetic changes there so that the docs matches is, e.g. the Dockerfile. |
Marking this as a draft since the docs contains information and steps that assume Yarn to be enabled which it's not yet. This PR can still be reviewed in the meantime though, we should only postpone its merging until the very last moments before releasing support for Yarn v3. |
|
Depends on #440 |
18b64da
to
6adc314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
STONEBLD-1691 Signed-off-by: Erik Skultety <[email protected]>
714a6a7
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)