Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn: add integration test for missing lockfile #444

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ejegrova
Copy link

@ejegrova ejegrova commented Jan 5, 2024

Adding test for a yarn project which is missing a lockfile. This results in failure in cachi2.

STONEBLD-2075

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • N/A Docs updated (if applicable)
  • N/A Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

@ejegrova
Copy link
Author

ejegrova commented Jan 5, 2024

tests/integration/test_yarn.py Outdated Show resolved Hide resolved
tests/integration/test_yarn.py Outdated Show resolved Hide resolved
Adding test for a yarn project which is missing a lockfile. This results
in failure in cachi2.

STONEBLD-2075

Signed-off-by: ejegrova <[email protected]>
Copy link
Contributor

@taylormadore taylormadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ejegrova ejegrova added this pull request to the merge queue Jan 9, 2024
Merged via the queue into containerbuildsystem:main with commit 58ea2b0 Jan 9, 2024
15 checks passed
@ejegrova ejegrova deleted the missing_lockfile branch January 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants