Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for updating global ARGs #118

Open
MartinBasti opened this issue Mar 17, 2021 · 0 comments
Open

Add support for updating global ARGs #118

MartinBasti opened this issue Mar 17, 2021 · 0 comments
Labels
help wanted

Comments

@MartinBasti
Copy link
Contributor

ARGs defined before first FROM in dockerfile are considered to be global ARGs and can be inherited into stages.

https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact

An ARG declared before a FROM is outside of a build stage, so it can’t be used in any instruction after a FROM. To use the default value of an ARG declared before the first FROM use an ARG instruction without a value inside of a build stage

Add ability to list and update global ARGs
@MartinBasti MartinBasti mentioned this issue Mar 17, 2021
Closed
openstack-mirroring pushed a commit to openstack/tripleo-ci that referenced this issue Sep 20, 2022
@bshewale
Add support for tcib_extra_config for master branch only
0492c16 
OSBS tool used in downstream to build wallaby container
doesnot support taking ARGS from FROM label in Dockerfile[1].
It is blocking the container build job[2].
So enabling tcib_extra_config for master only unblocks the line.

Links:
[1]. containerbuildsystem/dockerfile-parse#118
[2]. https://bugzilla.redhat.com/show_bug.cgi?id=2128230

Change-Id: I4b68432080e6c87d60e281acd8dae994e85e2e01
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Sep 20, 2022
@bshewale @openstack-gerrit
Update git submodules
437cdb5 
* Update tripleo-ci from branch 'master'
  to 0492c16aadc4d2008cbacf58f934e2348b3397f9
  - Add support for tcib_extra_config for master branch only
    
    OSBS tool used in downstream to build wallaby container
    doesnot support taking ARGS from FROM label in Dockerfile[1].
    It is blocking the container build job[2].
    So enabling tcib_extra_config for master only unblocks the line.
    
    Links:
    [1]. containerbuildsystem/dockerfile-parse#118
    [2]. https://bugzilla.redhat.com/show_bug.cgi?id=2128230
    
    Change-Id: I4b68432080e6c87d60e281acd8dae994e85e2e01
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Sep 23, 2022
@chkumar246 @openstack-gerrit
Update git submodules
ba5fcec 
* Update tripleo-common from branch 'master'
  to e310a3ced099cf3a4050d2337cf1cd0c1f1f4065
  - Drop ANSIBLE_RUNNER_IMAGE from tcib_args
    
    In Downstream, Openshift Build System(OSBS) is used to build
    the container image.
    
    In tripleo-ansible-ee yaml file, ANSIBLE_RUNNER_IMAGE is overriden
    via tcib_args during tcib container build process but
    OSBS does not overrides the ANSIBLE_RUNNER_IMAGE arg from FROM
    instructions due to
    containerbuildsystem/dockerfile-parse#118.
    
    It is not clear when the above issue will get fixed.
    In order to unblock the pipeline and to have a proper fix
    in place, we are going to using the default image name in tcib_from
    argument.
    
    In Downstream, tcib_from will be overriden with downstream
    image.
    
    Related-Bug: rhbz#2128230
    
    Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
    Change-Id: I81f911500ba620b27707075ef4fda8d52b2a5831
openstack-mirroring pushed a commit to openstack-archive/tripleo-common that referenced this issue Sep 23, 2022
@chkumar246
Drop ANSIBLE_RUNNER_IMAGE from tcib_args
e310a3c 
In Downstream, Openshift Build System(OSBS) is used to build
the container image.

In tripleo-ansible-ee yaml file, ANSIBLE_RUNNER_IMAGE is overriden
via tcib_args during tcib container build process but
OSBS does not overrides the ANSIBLE_RUNNER_IMAGE arg from FROM
instructions due to
containerbuildsystem/dockerfile-parse#118.

It is not clear when the above issue will get fixed.
In order to unblock the pipeline and to have a proper fix
in place, we are going to using the default image name in tcib_from
argument.

In Downstream, tcib_from will be overriden with downstream
image.

Related-Bug: rhbz#2128230

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
Change-Id: I81f911500ba620b27707075ef4fda8d52b2a5831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinBasti