add openetelemetry_info to user_params
#1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmodi
force-pushed
the
otel
branch
6 times, most recently
from
36e1b72
to
60218e3
Compare
hjmodi
force-pushed
the
otel
branch
4 times, most recently
from
8818ceb
to
eadd01e
Compare
the outdated versions are getting random error messages so updating to recent fedora versions fixes that Signed-off-by: Harsh Modi <[email protected]>
hjmodi
force-pushed
the
otel
branch
16 times, most recently
from
72ba900
to
f510bfc
Compare
hjmodi
force-pushed
the
otel
branch
11 times, most recently
from
b8a7cbf
to
108c780
Compare
rcerven
approved these changes
Sep 12, 2023
|
@hjmodi I have the same question here as in atomic-reactor PR regarding the commit messages |
|
we can add that otel_url https://github.com/containerbuildsystem/osbs-client/blob/master/docs/configuration_file.md and I'd say that is all we need to document |
This option will point to the OpenTelemetry Collector root URL. This is where all opentelemetry traces will be sent. * MMENG-3834 Signed-off-by: Harsh Modi <[email protected]>
This will be a dictionary containing, `otel_url` and `traceparent`. There are used in tekton tasks to initialize opentelementry and send traces to opentelemetry collector * MMENG-3834 Signed-off-by: Harsh Modi <[email protected]>
expecially tasks with http requests. This will allow us to get traces for all important HTTP calls. We are also collecting all args provided by the user for the build * MMENG-3834 Signed-off-by: Harsh Modi <[email protected]>
mkosiarc
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section