Support digest for input image in convertor #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The userspace convertor requires an
--input-tag
to identify the image to convert (USERSPACE_CONVERTOR.md).This is sometimes inconvenient because:
This PR supports a parameter to specify the digest of the image to convert, as an enhancement.
With this change, the command accepts either a tag (
--input-tag
) or a digest (--input-digest
) to specify the image to convert.Example usage with the digest parameter:
Manual test
I built the convertor locally, and ran it to convert an image with digest to verify it works:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #284
Please check the following list: