Fix userspace convertor output tagging on manifest dedup #312
+97
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicated manifests now account for possible adjustments to output tag. Updated tests and test resources to account for this scenario. Signed-off-by: Esteban <[email protected]>
estebanreyl
force-pushed
the
esrey/bugfix-tags-on-manifest-deduplication
branch
from
11e7716
to
9d992a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deduplicated manifests not accounting for possible adjustments to output tag. It also includes unit tests as well as updates to the validation scripts that help test such scenarios in a local environment. I was able to validate the change with my own registry as well. Thanks to @fourierrr for their earlier pr and opening the issue.
What this PR does / why we need it: This is a bugfix to address the scenario where a user wants to convert a previously converted image but expects a different output tag than the original. Without this change the user's converted image may end up being untagged or at least not referenced by the expected tag.
Fixes #310
Please check the following list: