You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
manager.Stat() iterates over enabled controllers to construct statistics, namely for memory and CPU. If a controller is not enabled, the statistics are not provided.
However, regardless of whether the cpu controller is enabled, cgroups v2 always provides the following statistics in cpu.stat :
usage_usec
user_usec
system_usec
Systemd no longer enables this controller when the property CPUAccounting=True, meaning these statistics are not provided when they probably should be. Stat() should be modified to fix this.
The unified hierarchy provides the cpu.stat file for every cgroup,
regardless if the CPU controller is enabled (in fact, setting the
systemd property CPUAccounting=True does not enable this controller
because of this fact). It provides the usage_usec, user_usec,
and system_usec by default. Instead of reading the stat for each
enabled controller (CPU and memory), just attempt to read them
each time the Stat() function is called.
Attempting to read the memory.stat file even if memory accounting
is not enabled seems insignificant (some other files always have
a read attempt, such as memory.current), and eliminates finding and
looping over enabled controllers.
Resolves: containerd#347
Signed-off-by: Jackson McKay <[email protected]>
manager.Stat()
iterates over enabled controllers to construct statistics, namely for memory and CPU. If a controller is not enabled, the statistics are not provided.cgroups/cgroup2/manager.go
Lines 565 to 575 in 0c03de4
However, regardless of whether the
cpu
controller is enabled, cgroups v2 always provides the following statistics incpu.stat
:usage_usec
user_usec
system_usec
Systemd no longer enables this controller when the property
CPUAccounting=True
, meaning these statistics are not provided when they probably should be.Stat()
should be modified to fix this.See https://docs.kernel.org/admin-guide/cgroup-v2.html#cpu-interface-files, systemd/systemd#10507
The text was updated successfully, but these errors were encountered: