Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgroup v1: implement AddProc() #200

Merged
merged 1 commit into from
Jul 15, 2021
Merged

cgroup v1: implement AddProc() #200

merged 1 commit into from
Jul 15, 2021

Conversation

thaJeztah
Copy link
Member

This implements AddProc() for cgroups v1 to make the API a closer match with the cgroupsv2 API.

@thaJeztah
cgroup v1: implement AddProc()
6659093 
This implements AddProc() for cgroups v1 to make the API a closer match
with the cgroupsv2 API.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah closed this Jul 15, 2021
@thaJeztah thaJeztah reopened this Jul 15, 2021
@thaJeztah thaJeztah mentioned this pull request Jul 15, 2021
Merged
@thaJeztah
Copy link
Member Author

Relates to / see containerd/containerd#5738

@thaJeztah thaJeztah marked this pull request as ready for review July 15, 2021 08:33
@thaJeztah thaJeztah mentioned this pull request Jul 15, 2021
Merged
Zyqsempai
Zyqsempai approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuweid
fuweid approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@fuweid fuweid merged commit e6ce30d into containerd:main Jul 15, 2021
@thaJeztah thaJeztah deleted the add_cgroupv1_addproc branch July 15, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @Zyqsempai @AkihiroSuda @fuweid