Improvements on cgroup v2 support #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miao Wang <[email protected]>
…ritten As stated originally in the comment, ``the user may face EPERM on parent groups", it should not be an error when writing to grand-parent groups fails but writing to the last one succeeds. Signed-off-by: Miao Wang <[email protected]>
AkihiroSuda
approved these changes
Jul 27, 2021
sameo
approved these changes
Jul 27, 2021
mxpv
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pr contains two improvements on cgroupv2 support.
manager.NewChild(), resources limits are set before the corresponding controllers are enabled. The patch fixes this issue following the way how it is dealt inNewManager()manager.ToggleControllers(), the settings are written recursively from root controller tom's parent. As long as its parent is successfully written with the given settings, all possible errors happens before can safely ignored.