Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update to go1.19 as minimum, and add go1.22.x to GHA #342

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

thaJeztah
Copy link
Member

go.mod: update to go1.19 as minimum

This is the oldest version tested in CI, so set this as the
minimum version.

gha: also test on go1.22.x

This is the oldest version tested in CI, so set this as the
minimum version.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah self-assigned this Jun 21, 2024
@@ -50,7 +50,7 @@ jobs:

strategy:
matrix:
go-version: [1.19.x, 1.20.x]
go-version: [1.19.x, 1.21.x, 1.22.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop 1.19

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my thinking here was to keep a minimum version (unless we had a strong reason to drop it), then check current versions.

I'm fine with dropping 1.19 by now probably, although "if it works", then 🤷 .

I'll drop the 1.20, and keep the upper-bound to 1.21, 1.22 as suggested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! I read the diff wrong, thought it was a suggestion, but I already changed to 1.21, 1.22 🤦 😂

@dmcgowan dmcgowan merged commit 29eaa5d into containerd:main Jun 21, 2024
11 checks passed
@thaJeztah thaJeztah deleted the update_go_versions branch June 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants