Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate RunningInUserNS(), migrate to github.com/moby/sys/userns #346

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 16, 2024

The userns package in libcontainer was integrated into the moby/sys/user module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends on runc/libcontainer, or on containerd, both of which have a complex dependency tree. This patch is part of a series of patches to unify the implementations, and to migrate toward that implementation to simplify the dependency tree.

@thaJeztah thaJeztah self-assigned this Jul 16, 2024
@thaJeztah thaJeztah force-pushed the migrate_userns branch 2 times, most recently from ce266ee to b373ab6 Compare July 16, 2024 22:19
@thaJeztah thaJeztah force-pushed the migrate_userns branch 2 times, most recently from f9f277d to e6a9f49 Compare July 25, 2024 12:05
@thaJeztah thaJeztah marked this pull request as ready for review July 25, 2024 13:19
@thaJeztah thaJeztah requested review from kzys and dmcgowan July 25, 2024 13:19
@thaJeztah thaJeztah marked this pull request as draft August 6, 2024 10:53
@thaJeztah
Copy link
Member Author

temporarily moving to draft; pending moby/sys#140 (comment)

The userns package in libcontainer was integrated into the moby/sys/user
module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends
on runc/libcontainer, or on containerd, both of which have a complex
dependency tree. This patch is part of a series of patches to unify the
implementations, and to migrate toward that implementation to simplify
the dependency tree.

[3778ae603c706494fd1e2c2faf83b406e38d687d]: opencontainers/runc@3778ae6

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review August 8, 2024 11:20
@thaJeztah
Copy link
Member Author

Okay; updated; this should be good for review again /cc @dmcgowan

@thaJeztah
Copy link
Member Author

@dmcgowan ptal 🤗

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 190de3b into containerd:main Aug 29, 2024
8 checks passed
@thaJeztah thaJeztah deleted the migrate_userns branch August 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants